Hi Eric,
* Eric Blake wrote on Tue, Oct 21, 2008 at 06:40:23PM CEST:
> Comments or objections to this version of the patch?
Looks good to me (untested), except one minor nit.
> @@ -12163,7 +12188,10 @@ Polymorphic Variables
> @defmac AS_VAR_SET (@var{var}, @ovar{value})
> @asindex{VAR_SET}
> Emit shell code to assign the contents of the polymorphic shell variable
> [EMAIL PROTECTED] to the shell expansion of @var{value}.
> [EMAIL PROTECTED] to the shell expansion of @var{value}. @var{value} is not
> +subject to field splitting or file name expansion, so if command
> +substitution is used, it should be done with @samp{`""`} rather than
> [EMAIL PROTECTED]"`""`"} (@pxref{Shell Substitutions}).
> @end defmac
This sounds a bit like, if field splitting were happening, then "`""`"
would have been a good idea. Since that's not the case even in those
circumstances, how about rewriting it as
@var{var} to the shell expansion of @var{value}. @var{value} is not
subject to field splitting or file name expansion, so if command
substitution is used, it may be done with @samp{`""`} rather than
using an intermediate variable (@pxref{Shell Substitutions}).
Thanks!
Ralf
