-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to William Pursell on 12/7/2008 12:11 AM: > + Fix AC_HEADER_ASSERT to honor --enable-assert, rather than > + treat --enable-assert and --disable-assert equivalently. > + * lib/autoconf/headers.m4 > +
Thanks for the idea; it is certainly a step in the right direction. However, would you mind resubmitting with some additional nits fixed? > AC_MSG_CHECKING([whether to enable assertions]) > AC_ARG_ENABLE([assert], > [ --disable-assert turn off assertions], We should be promoting the use of AS_HELP_STRING on this line, > - [AC_MSG_RESULT([no]) > - AC_DEFINE(NDEBUG, 1, [Define to 1 if assertions should be disabled.])], > + [ if test "x$enableval" != xyes; then this could be done with AS_IF, although that is not a necessity, > + AC_MSG_RESULT([no]) > + AC_DEFINE(NDEBUG, 1, [Define to 1 if assertions should be disabled.]) we should promote proper m4 quoting on this line, > + else > + AC_MSG_RESULT([yes]) > + fi ], and trailing whitespace is smashed by autom4te, so it doesn't make sense to document it. > [AC_MSG_RESULT(yes)]) You might want to simplify by doing a single AC_MSG_RESULT([$enable_assert]) after the conclusion of AC_ARG_ENABLE, rather than repeating a hardcoded the yes/no in each branch. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkk73egACgkQ84KuGfSFAYCK9wCePYW1EzGgN4C0KfoRF8SfZxML m80An0JqpnRSdeG3K4V+oOWjTHo7WB3t =rG4K -----END PGP SIGNATURE-----
