-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Paolo Bonzini on 1/23/2009 5:15 AM: >> -[AC_HEADER_DIRENT >> -AC_FUNC_CLOSEDIR_VOID >> +[AC_FUNC_CLOSEDIR_VOID > > This is wrong, especially if someone uses autoupdate. Given that the > users of these are ~0, I'd rather keep the warning in this case.
How so? AC_FUNC_CLOSEDIR_VOID already does an AC_REQUIRE([AC_HEADER_DIRENT]), so there is no change in output. On the other hand, I wrote this patch prior to my subsequent patch to make autoconf silent on the direct expand then require, and I suspect this should fall in that category of warnings that were silenced. So if reverting just this patch is now silent, then it seems like the right thing to do. I'll be testing that tomorrow. - -- Don't work too hard, make some time for fun as well! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkl6oS4ACgkQ84KuGfSFAYBXpwCfZiNz7BsumwwVFiz1LjtLs9LQ HJcAnjdHp3k/8jUe2GcGSD229TMytmns =217v -----END PGP SIGNATURE-----
