Hi Eric, * Eric Blake wrote on Wed, Jan 28, 2009 at 12:36:12AM CET: > > The patch series now stands at the following: The first three fix --help > output of: autoconf's executables, built configure/config.status files, and > built testsuites; and the fourth adds an undocumented macro > m4_copyright_condense, useful for making autoconf's './configure --version' > output match GNU standards of only displaying the most recent year. What do > you think?
Overall the series looks ok to me. `./config.status --version' output of Autoconf itself (re-autoreconf'ed) is missing a year, though. Is that tested? > Should I go ahead and document that macro, or the fact that I > tweaked A[CT]_COPYRIGHT to take an optional filter parameter? I don't see the need of it yet. > If we do document it, should we reorder AC_COPYRIGHT's parameters to > make the filter second and diversion name third (as I want to leave > the diversion name argument undocumented)? Why go backward incompatible if you don't have to? > $ git pull git://repo.or.cz/autoconf/ericb.git help Thanks, providing a git tree makes reviewing easier. > m4_define([_AC_INIT_PACKAGE], > [AS_LITERAL_IF([$1], [], [m4_warn([syntax], [AC_INIT: not a literal: $1])]) > AS_LITERAL_IF([$2], [], [m4_warn([syntax], [AC_INIT: not a literal: $2])]) > @@ -266,6 +267,11 @@ m4_ifndef([AC_PACKAGE_STRING], > [m4_define([AC_PACKAGE_STRING], [$1 $2])]) > m4_ifndef([AC_PACKAGE_BUGREPORT], > [m4_define([AC_PACKAGE_BUGREPORT], [$3])]) > +m4_ifndef([AC_PACKAGE_URL], > + [m4_define([AC_PACKAGE_URL], > + m4_if([$5], [], [m4_if(m4_index([$1], [GNU ]), [0], > + [[http://www.gnu.org/software/]m4_defn([AC_PACKAGE_TARNAME])[/]])], > + [[$5]]))]) > ]) Isn't that last $5 over-quoted? Ah, no, that outer m4_if is evaluated early, sorry. Thanks, Ralf
