Hi Eric, * Eric Blake wrote on Fri, Apr 24, 2009 at 04:54:21PM CEST: > Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes: > > > > I'm thinking of applying this series; any problems? > > > > The first (very minor) one that I see is that your log messages are not > > verbose enough for me to follow. For example, this: > > Addressed in the refactored series, shown below. I'll wait a couple more > hours > for any other comments.
Looks good to me. Thanks! > > Bummer we're moving away from using AC_DEFUN, AU_DEFUN, and autoupdate, > > in favor of m4_* nowadays. > > AC_DEFUN won't work (this is the autotest language of autom4te, but AC_DEFUN > is > in the autoconf language). Does anyone really use AU_DEFUN on autotest? Can't imagine anyone doing it. My comment was more of a "wouldn't it be nice if ...", but luckily, there is no real need for autoupdating autotest sources. We should try hard to keep it (the lack of need) that way. > At > any rate, I'm not even sure autoupdate knows how to interact with the > autotest > language. So for this particular obsoletion, m4_define is the only method > available. Agreed. Cheers, Ralf
