-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Paolo Bonzini on 6/15/2009 6:24 AM: > No, the right way to update _AC_CHECK_HEADER_OLD is > > AU_DEFUN([_AC_CHECK_HEADER_OLD], > [AC_CHECK_HEADER([$1], [$2], [$3], [-])]) > > Ok to commit the obvious patch?
Good thing I hadn't pushed yet. Here's my rewrite: - -- Don't work too hard, make some time for fun as well! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAko2P34ACgkQ84KuGfSFAYDMAACeIHw2iLhhUYZnQGgQvlt1Kgaa 9BQAn3rljGBn0jYyAChITPZyi20I2SLJ =BV0l -----END PGP SIGNATURE-----
>From ac58d9542b268f330a3c549a32170c9ba91b32ef Mon Sep 17 00:00:00 2001 From: Eric Blake <[email protected]> Date: Mon, 15 Jun 2009 06:21:06 -0600 Subject: [PATCH] Reinstate _AC_CHECK_HEADER_OLD for gcc. * lib/autoconf/headers.m4 (_AC_CHECK_HEADER_NEW) (_AC_CHECK_HEADER_OLD): Provide autoupdate versions, since gcc and others used these undocumented macros. Reported by Ralf Wildenhues. Signed-off-by: Eric Blake <[email protected]> --- ChangeLog | 8 ++++++++ lib/autoconf/headers.m4 | 14 ++++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index f474f70..0375ff4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2009-06-15 Eric Blake <[email protected]> + + Reinstate _AC_CHECK_HEADER_OLD for gcc. + * lib/autoconf/headers.m4 (_AC_CHECK_HEADER_NEW) + (_AC_CHECK_HEADER_OLD): Provide autoupdate versions, since gcc and + others used these undocumented macros. + Reported by Ralf Wildenhues. + 2009-06-11 Steven G. Johnson <[email protected]> and Eric Blake <[email protected]> diff --git a/lib/autoconf/headers.m4 b/lib/autoconf/headers.m4 index 120adc9..6ba0b91 100644 --- a/lib/autoconf/headers.m4 +++ b/lib/autoconf/headers.m4 @@ -194,6 +194,13 @@ AC_DEFUN([_AC_CHECK_HEADER_COMPILE], AS_VAR_IF([ac_Header], [yes], [$2], [$3]) AS_VAR_POPDEF([ac_Header])])# _AC_CHECK_HEADER_COMPILE +# _AC_CHECK_HEADER_NEW(HEADER-FILE, [ACTION-IF-FOUND], +# [ACTION-IF-NOT-FOUND]) +# ---------------------------------------------------- +# Some packages used this macro, even though it is undocumented. +AU_DEFUN([_AC_CHECK_HEADER_NEW], +[AC_CHECK_HEADER([$1], [$2], [$3], [AC_INCLUDES_DEFAULT])]) + # _AC_CHECK_HEADER_PREPROC_BODY # ----------------------------- @@ -225,6 +232,13 @@ AS_VAR_IF([ac_Header], [yes], [$2], [$3]) AS_VAR_POPDEF([ac_Header])dnl ])# _AC_CHECK_HEADER_PREPROC +# _AC_CHECK_HEADER_OLD(HEADER-FILE, [ACTION-IF-FOUND], +# [ACTION-IF-NOT-FOUND]) +# ---------------------------------------------------- +# Some packages used this macro, even though it is undocumented. +AU_DEFUN([_AC_CHECK_HEADER_OLD], +[AC_CHECK_HEADER([$1], [$2], [$3], [-])]) + # _AH_CHECK_HEADER(HEADER-FILE) # ----------------------------- -- 1.6.3.rc3.2.g4b51
