-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Eric Blake on 7/7/2009 3:12 PM: > Meanwhile, I think the best course of action is to just teach > AT_SKIP_PARALLEL_TESTS to recognize 'set -m' as another reason to skip rather > than fail. Hmm. Maybe I should factor the autotest/general.m4 conditions > into > something that can be more easily reused in autotest.at, rather than having > to > keep the two filters in sync.
Done as follows. - -- Don't work too hard, make some time for fun as well! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpUKE4ACgkQ84KuGfSFAYCIpgCcC6SMuRqyr5gE4zwbnI5pK5U6 DIUAnj7VbNYDzbdxD+R2GJXbJaYIqM18 =FISp -----END PGP SIGNATURE-----
>From 9a15f2f077736b7d52ce01b6102ee9a495f02452 Mon Sep 17 00:00:00 2001 From: Eric Blake <[email protected]> Date: Tue, 7 Jul 2009 23:01:23 -0600 Subject: [PATCH] Skip parallel tests when zsh 'set -m' fails. * tests/autotest.at (AT_SKIP_PARALLEL_TESTS): Skip test if set -m is not supported. Reported by Ralf Wildenhues. Signed-off-by: Eric Blake <[email protected]> --- ChangeLog | 5 +++++ tests/autotest.at | 3 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index ff8e9ce..fed334e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2009-07-07 Eric Blake <[email protected]> + Skip parallel tests when zsh 'set -m' fails. + * tests/autotest.at (AT_SKIP_PARALLEL_TESTS): Skip test if set -m + is not supported. + Reported by Ralf Wildenhues. + Make parallel testsuite more portable. * lib/autotest/general.m4 (AT_INIT) <AT_JOB_FIFO_FD>: Avoid <>; instead open write descriptor in each group and read descriptor in diff --git a/tests/autotest.at b/tests/autotest.at index b4ba887..9bdb728 100644 --- a/tests/autotest.at +++ b/tests/autotest.at @@ -992,8 +992,9 @@ m4_define([AT_SKIP_PARALLEL_TESTS], # limited conditions; help is appreciated in widening this test base. AT_CHECK([${CONFIG_SHELL-$SHELL} -c 'test -n "${BASH_VERSION+set}]]dnl [[${ZSH_VERSION+set}${TEST_PARALLEL_AUTOTEST+set}"' || exit 77]) -# The parallel scheduler requires mkfifo to work. +# The parallel scheduler requires mkfifo and job control to work. AT_CHECK([mkfifo fifo || exit 77]) +AT_CHECK([${CONFIG_SHELL-$SHELL} -c '(set -m && set +m) || exit 77']) ]) -- 1.6.3.3.334.g916e1
