Hi Paolo,
* Paolo Bonzini wrote on Sun, Jul 12, 2009 at 01:09:54PM CEST:
> --- a/doc/autoconf.texi
> +++ b/doc/autoconf.texi
> @@ -22653,6 +22653,42 @@ Writing Testsuites
> Several identical calls within one test group have no additional effect.
> @end defmac
>
> +...@defmac AT_FAIL_IF (@var{shell-condition})
> +...@atindex{fail_if}
> +Make the test should fail and skip the rest of its execution if
s/should/group/ ?
> +...@var{shell-condition} is true. @var{shell-condition} a shell expression
s/ a / is&/ =
Two spaces after period are normal. More instances below.
> +such as a @code{test} command. Tests before @command{AT_FAIL_IF}
> +will be executed and may still cause the test group to be skipped.
> +You can instantiate this macro many times from within the same test group.
> +
> +You should use this macro only for very simple failure conditions. If the
> +...@var{shell-condition} could emit any kind of output you should instead
> +use @command{AT_CHECK} like
> +...@example
> +AT_CHECK([...@var{shell-condition}] || exit 99)
> +...@end example
> +...@noindent
> +so that such output is properly recorded in @file{testsuite.log}.
in the @file{testsuite.log} file.
> +...@end defmac
I haven't looked at the implementations in detail, but at a ten second
glance this and your other patches all looked basically sane to me.
I'm sure Eric will provide a much better review.
Thanks,
Ralf
