-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Romain Lenglet on 7/23/2009 8:44 AM: > On Thursday 23 July 2009 22:57:36 Romain Lenglet wrote: >> This allows us to test all the macros using AT_CHECK_MACRO, which is much >> cleaner and concise. >> Cf. the attached diff against the latest master branch. >> Sorry for the delay for sending you that patch! > > Ooops, scratch that. > That latest patch was buggy, sorry. > > Attached is a working version of that latest patch.
More tweaks needed. Your changelog entry should call out macro names affected (sorry I didn't catch that last time). 'test ... -o ...' is not portable, you must use 'test ... || test ...'. Also, 'git format-patch' gives nicer output that 'git diff'; in part because it includes the author name and date and commit message. I'm guessing that the deletion in tests/Makefile.am was intentional, since your ChangeLog didn't mention it. At any rate, I've applied this (if for no other reason than the namespace improvement is good); please review again. - -- Don't work too hard, make some time for fun as well! Eric Blake [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkppHvQACgkQ84KuGfSFAYCqKACeMj5hKN4QBoCSxt//uTyu9aCN reMAnRbHSa0Z13lJMaIqGVBz4RDdSEV+ =zLwu -----END PGP SIGNATURE-----
