According to Ralf Wildenhues on 2/28/2010 10:12 AM: > The testsuite passed on FreeBSD with the two patches applied. > > > The trace lines for the two commands in the pipeline are intermingled. > Ugh.
Indeed. If nothing else, autoconf is a great testing ground for sniffing out some really hideous bugs in various shells. > > I know this will make you weep, killing off some of that precious m4 > time you worked so hard for; but just matching for | gives lots of false > positives that have ||, even [^|]|[^|] has quite a few false positives > from egrep and sed 's|||' commands which I don't know how to avoid. I don't see any way around a regexp, without paying the penalty for more false positives on non-pipelines. > > Fix Autotest tracing of shell pipelines for FreeBSD sh. > > * lib/autotest/general.m4 (_AT_DECIDE_TRACEABLE): Do not trace > commands that contain [^|]|[^|], a likely shell pipeline. > * tests/local.at (_AT_CHECK_ENV): Turn off tracing for egrep | > grep pipeline. > * doc/autoconf.texi (File Descriptors): Document limitation. > * tests/autotest.at (Trace output): New test. > > Signed-off-by: Ralf Wildenhues <[email protected]> The patch looks good; please apply. -- Don't work too hard, make some time for fun as well! Eric Blake [email protected]
signature.asc
Description: OpenPGP digital signature
