* Eric Blake wrote on Thu, Mar 04, 2010 at 09:36:14PM CET: > According to Ralf Wildenhues on 3/4/2010 1:23 PM: > > > So the latter > > isn't only an optimization, and the former has the potential to break > > user code; as AS_BOX wasn't documented until now, users would have to > > reimplement it, possibly using the exact code that the old AS_BOX had. > > AS_BOX and m4_text_box are not tested in the testsuite BTW. > > m4_text_box is tested if AS_BOX is tested.
Pedantically, no. You can rename m4_text_box to foo_bar throughout lib/* and you have an API regression the testsuite won't find. That's not quite but almost like the AC_LANG_SOURCE issue. I really think that all documented APIs should be tested individually. Cheers, Ralf
