On 06/06/2010 05:56 AM, Ralf Wildenhues wrote: > Without the URL change, the results are documented wrongly in the > manual, missing > #define PACKAGE_URL "" > > so this might be nice before 2.66. OK?
Given that argument, yes, this looks fine. > > The second patch has the downside of requiring maintenance should the > formatting of the source contents change. I only saw one patch? But I'm okay with the slight maintenance burden if the file contents change slightly; at least with an automated test, we are more likely to notice it as it happens, and decide at that time if (and how) the test can be relaxed. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
