On 06/06/2010 05:45 AM, Ralf Wildenhues wrote: > [ http://lists.gnu.org/archive/html/autoconf-patches/2010-03/msg00000.html ] > > * Ralf Wildenhues wrote on Mon, Mar 01, 2010 at 11:01:04PM CET: >> This is not for 2.66, even if it gets done before the release. > > Well, but since it's been a while, and the patch is fairly low danger, > I'll ping it anyway. OK to commit? Now or after 2.66? > > Thanks, > Ralf > >> Testsuite coverage for AC_CACHE_VAL and caching semantics.
I'm now failing this test: > ./base.at:406: ./configure $configure_options > --- /dev/null 2010-06-07 19:59:35.029384621 -0600 > +++ /home/remote/eblake/autoconf/tests/testsuite.dir/at-groups/205/stderr > 2010-06-08 03:38:57.257505619 -0600 > @@ -0,0 +1 @@ > +./configure: line 1545: .: config.site: file not found > stdout: > configure: loading site script config.site > checking whether true(1) works... yes > configure: creating ./config.status > config.log: It looks like configure tried to call . "$ac_site_file" when $CONFIG_SITE was set to an in-directory file; remember that . does not automatically add the current directory to its search path, and that to be portable you have to use CONFIG_SITE=./config.site rather than just CONFIG_SITE=config.site. For that matter, POSIX only barely just admitted that support for '. -- "$file"' is not required (yet), and therefore, it is not very portable to try sourcing an arbitrary file name provided by a user since that name might start with a dash: http://austingroupbugs.net/view.php?id=252 Meanwhile, we are failing to detect any errors that might occur while sourcing an existing but broken site file, because we don't check for non-zero status after sourcing the site file. I hope to look at improving lib/autoconf/general.m4 later today, if you don't beat me to it... -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
