----- "Stefano Lattarini" <[email protected]> wrote: > Hello Eric. > > At Friday 02 July 2010, Eric Blake wrote: > > * lib/m4sugar/m4sh.m4 (_AS_TR_CPP_LITERAL): Avoid underquoting. > > (_AS_TR_CPP_INDIR): Handle all polymorphic variables. > > * tests/m4sh.at (AS@&t...@_tr_sh and AS@&t...@_tr_cpp): New test. > > * NEWS: Document the fix. > > Reported by Bruno Haible. > > > > +echo === > > +[var=abc vAr=aBc VAR=ABC] > > +echo AS_TR_SH($var) AS_TR_SH($vAr) AS_TR_SH($VAR) > > +echo AS_TR_SH([$var]) AS_TR_SH([$vAr]) AS_TR_SH([$VAR]) > > +echo AS_TR_SH([[$var]]) AS_TR_SH([[$vAr]]) AS_TR_SH([[$VAR]]) > > +echo AS_TR_CPP($var) AS_TR_CPP($vAr) AS_TR_CPP($VAR) > > +echo AS_TR_CPP([$var]) AS_TR_CPP([$vAr]) AS_TR_CPP([$VAR]) > > +echo AS_TR_CPP([[$var]]) AS_TR_CPP([[$vAr]]) AS_TR_CPP([[$VAR]]) > > +echo === > > +var=abc vAr=aBc VAR=ABC > I've just thrown a quick glance at your patch, so this might be a > stupid > question... but what are these assignements above required for?
Copy-and-paste leftovers. The second set of assignments is not needed, and a patch to delete that line would be fine with me. I'm about to head on vacation for two weeks, so I will not be pushing the patch for this particular issue until after then (I'm hoping that I can solve the more important problems with AC_SIZEOF before I head out). -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
