On 07/19/2010 11:56 AM, Eric Blake wrote:
> On 07/19/2010 11:43 AM, Ralf Wildenhues wrote:
>> The AC_EGREP_CPP macro already allows to test preprocessor output, but
>> this addition can be helpful if you want to answer two questions with
>> only one run of the preprocessor.  Also, it is in line with
>> AC_COMPILE_IFELSE and AC_LINK_IFELSE allowing inspection of output in
>> the if-true branch.
> 
> I like it!  Please apply, after addressing one nit...

Actually, more than one nit - I'm now seeing testsuite failures, such as:

260. aclang.at:14: testing AC_REQUIRE_CPP ...
...
./aclang.at:14: at_check_env
--- /dev/null   2010-07-19 08:58:05.813000001 -0600
+++
/home/remote/eblake/autoconf/tests/testsuite.dir/at-groups/260/stdout
    2010-07-19 16:58:39.724950003 -0600
@@ -0,0 +1,9 @@
+--- state-ls.before    2010-07-19 16:58:38.848950003 -0600
++++ state-ls.after     2010-07-19 16:58:39.665950003 -0600
+@@ -3,5 +3,6 @@
+ confdefs.h
+ configure
+ configure.ac
++conftest.i
+ install-sh
+ testsuite.log

so we need to account for the existence of conftest.i in more tests.

-- 
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to