Den 2010-10-15 19:51 skrev Ralf Wildenhues: > Hi Peter, > > * Peter Rosin wrote on Fri, Oct 15, 2010 at 09:28:53AM CEST: >> I haven't actually tested the patch, but it seems trivial enough. > > Bzzt. You are just barely saved yourself by admitting it upfront! ;->
Oooops. >> --- a/lib/m4sugar/m4sh.m4 >> +++ b/lib/m4sugar/m4sh.m4 > >> else >> - as_ln_s='cp -p' >> -fi >> -rm -f conf$$ conf$$.exe conf$$.dir/conf$$.file conf$$.file >> -rmdir conf$$.dir 2>/dev/null >> + as_ln_s=$LN_S >> +endif > > Shell if ends with fi, not endif. Right. Must have been writing too many #ifdefs lately. >> ])# _AS_LN_S_PREPARE > > With that fixed, I ran the testsuite on GNU/Linux once without LN_S set, > once with export LN_S='cp -p', both successfully, but with LN_S=bla, the > only failure is from the foreign.at:Libtool test, because libtoolize > honors $LN_S. Wasn't that unexpectedly few failures for the last case? > I think a testsuite addition that ensures that LN_S is honored for both > AC_PROG_LN_S and for AS_LN_S is in order; we have already regressed on > this once, a few years ago. Please ping me if you want me to write one. I don't feel at home in the autoconf testsuite. It would probably take me quite a while to even understand where it would be natural to add it. Then how to add it. Then get up to speed with running the testsuite at all, which I have of course forgotten all about since the last time. But I hate putting more load on you, so I'll work my way through it. Pointers on where in the testsuite to add the new tests appreciated though, and perhaps a pointer to some test doing something similar. Cheers, Peter
