On 03/17/2011 04:50 PM, Stefano Lattarini wrote:
Hi Eric, and thanks for having solved this.
I have just a minor nit and a question below (sorry for not giving a
proper review, but I must admit some parts of your patch are way beyond
me ATM :-(, especially the new definition of AC_PACKAGE_TARNAME).
On Thursday 17 March 2011, Eric Blake wrote:
[CUT]
Note that this is a subtle semantic change. It used to be that you
could do:
m4_define([pkg_name], [foo])
AC_INIT([pkg_name], [1.0])
and that would result in AC_SUBST of PACKAGE_NAME=foo
With this patch, it results in PACKAGE_NAME=pkg_name.
>>
[CUT]
I don't see too much harm in making this change,
I do - If I understand this correctly, you are breaking a common trick
being used by "big packages". Mine are amongst those and IIRC and so are
others.
Ralf
