[dropping autoconf] On 01/23/2012 11:22 AM, Jim Meyering wrote: > Eric Blake wrote: >> This is allowed by recent GNU Coding Standards changes, and >> mirrors recent gnulib changes: >> https://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00267.html >> https://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00298.html >> >> I've confirmed that after these changes, the INSTALL generated and >> installed by autoconf matches the INSTALL.ISO in gnulib. >> >> * Makefile.am ($(srcdir)/INSTALL): Match gnulib INSTALL.ISO. >>
>> $(srcdir)/INSTALL: $(top_srcdir)/doc/install.texi >> echo @firstparagraphindent insert \ >> | cat - $(top_srcdir)/doc/install.texi > tmp.texi >> $(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS) \ >> - --plaintext -o $@ tmp.texi >> + --plaintext tmp.texi \ >> + | sed -e $(CONVERT_QUOTES) -e $(OMIT_TRAILING_EMPTY_LINES) > $@ > > Thanks. That looks fine except for the fact that the new rule redirects > directly to the target, $@. > > Please adjust it to use this idiom instead: > > ... > $@-t && mv $@-t $@ Thanks - and that's why I like reviews. Fixed and pushed. -- Eric Blake [email protected] +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
