I've attached a new diff that fixes that error in the code comments. 😊 > From: [email protected] > To: [email protected] > Subject: Re: Turn on compiler warnings by default for AC_PROG_CC, > AC_PROG_CXX & AC_PROG_FC > Date: Fri, 11 Apr 2014 15:23:33 -0400 > CC: [email protected]; [email protected] > > On Fri, 11 Apr 2014 08:33:01 -0400, Dale Visser <[email protected]> wrote: > > You found a mistake in the code comments that were brought over with > > this code from Autoconf Archive. > > Okay, hope you'll fix that! > > > To answer your specific question about GCC, only '-Wall' gets > > used to compile. > > Good, that makes way more sense. > > I like to also use "-Wextra" when using gcc. > If I understand patch correctly, I could then use: > AC_APPEND_CFLAG_IFVALID([-Wextra]) > It will then add "-Wextra"... but only if the compiler *accepts* that flag. > > BTW, I recently got a patch from someone on a project that > force-added "-Wall" to configure.ac. Dale Visser's addition to autoconf is > way better, > because it doesn't presume that "all the world is gcc". > > --- David A. Wheeler >
autoconf.diff
Description: Binary data
