| : Alexandre can judge, I can't.
|
| Well, what's not indentation fixes is mostly ifelse alternations without
| any "original work", so I think the patch only counts for the extra
| case/esac lines...
But I still want an alexandreward opinion anyway :)
| : | CONFIG_HEADERS= CONFIG_FILES=-:file.in config.status | \
| : | CONFIG_HEADERS=file:- CONFIG_FILES= config.status
| :
| : Gross :(
|
| Did I *say* it was elegant? ;)
:)
| : Hm, according to your code you do. Do we want things like:
| :
| : ./config.status --file=file:file.in:-
|
| That is incorrect use, and will therefore fail, and the person who wrote
| that would get what's coming to him...
Do you really want to make it incorrect? After all, why should it be
forbidden, almost nothing is needed to support this.
| : | + -) ac_file_in= ac_file= ;;
| : | + -:-) ac_file_in= ac_file= ;;
| : | + -:*) ac_file_in=`echo "$ac_file" | sed 's/^..//'` ac_file= ;;
| : | + *:-) ac_file_in= ac_file=`echo "$ac_file" | sed 's/..$//'` ;;
| [...]
| : In fact I don't understand why you prefer to have ac_file= instead of
| : keeping ac_file=-?
|
| On certain platforms, sed won't take input from stdin if you write
Yep, but I was referring with delaying the handling, as I suggested
with stdin.in.
| so I need the variables to be empty at those positions. I thought I could
| save a few tests by doing it this way.
Yep, you still need to test -n your var, it would just be a test != -.
| Yep, I was confused on this one - it seems like we're trying to avoid '!'
| as much as possible, but 'test string != string' should preferably be used
| to the obfuscation above.
There is no problem with ! as an argument to test, what's not portable
is using ! directly with if:
if !cmd; then...
| The file:-:file.in is, again, incorrect usage. You don't want to mix input
| from both stdin and files. Let those who try get what's coming to them ;)
Why don't you want to? Actually, why do you want stdin at all, we
leaved so long without... But you appear to need it anyway, so maybe
someone will come with that need some day.
In addition, still from the point of view of the documentation, it is
easier to say `-' represents stdin/stdout, than to have to explain
that when - is used to denote stdin, then you can't use other input
files.
Akim
