On Fri, 4 Feb 2005, Chris Feist wrote:
I'm working on a patch to get the get_best_mounts function (in modules/mount_nfs.c) work a little better and handle a few end cases.
Sounds great.
I really appreciate having Jeff and yourself helping out so much.
It's so much better to have people to challenge your thinking and contribute stuff to get the old grey matter wheels turning.
What was the skiplocal variable intended to do?
Good question. I'll have a look and get back.
I don't want to escape the blame for this but ...
When I first got that patch it looked fine but was badly broken. I've reworked the code a good number of times now so there's bound to be oddities in it that I've missed.
It seems that if it is not 0, the only thing that get_best_mount does is check and see if the 'what' string is null & if it isn't return 0. And the only time the get_best_mounts function is called with skiplocal set to 1. is when it is calling itself when all the hosts have not responded within 100ms.
Is it reasonable to completely remove this variable?
I'll have a look.
Ian
_______________________________________________ autofs mailing list [email protected] http://linux.kernel.org/mailman/listinfo/autofs
