On Sun, 3 Apr 2005, Jeffrey Layton wrote: > [EMAIL PROTECTED] wrote: > > > > > Thanks for that. > > > > As you probably realise adding this to the current beta is not a good > > idea as this needs to stabilise to go to release. Making a significant > > change like this at this time is a bad idea. So it's 4.1.5. At least > > your not alone, I have a couple of other patches. > > > > I'll have a look. > > > > One think I noticed is that there are places where there's a 4 > > character indent. While that's present in other places in the code I > > prefer a straight 8 char tab for all indents. Long lines are really > > bad as well and we should try our best to keep them short. I try to > > keep lines to 80 chars (but often don't succeed). > > > > The usual thinking is that if the code needs to be indented to far it > > needs to be restructured. > > > > Anyway they're my goals. > > Sounds good. I didn't expect this to go into 4.1.4 -- it's too big a > change for that, but if you could consider it for 4.1.5 that would be great.
Yep. I've already got a smallish list. > > I'll try to clean up the indenting and see if I shorten some of the > lines (maybe I'll take a stab at running it through "indent" first). > Most of the long lines are due to debug statements in the code, so some > of those can probably be removed once the code stabilizes a bit. There doesn't seem to be much of it. Perhaps it's more efficient to do it by hand. It's probably a good idea to laeve most of the debug stuff and break the lines at parameter boundries. Ian _______________________________________________ autofs mailing list autofs@linux.kernel.org http://linux.kernel.org/mailman/listinfo/autofs
