On Sun, 24 Apr 2005, Daniel Andre Vaquero wrote:
On Mon, Apr 25, 2005 at 02:10:14AM +0800, [EMAIL PROTECTED] wrote:On Sun, 24 Apr 2005, Daniel Andre Vaquero wrote:
I would also suggest a change in the name of this function to something like is_replicated_entry. Multi-mounts and replicated mounts are different things, and in this case it could confuse the reader.
Perhaps. But they are handled by the same code. The simple replicated mount entry is a special case of a multi-mount entry as far as the code is concerned. At least that's the way it is now.
Sorry, I didn't see that it is now also being used in parse_sun.c. Then I agree that it is OK.
I've removed those patches just now.
After thinking about it I think you were right.
I'm going to leave these tests seperate and rename the test as you suggest.
I have tested version 4.1.4 plus the three new patches from kernel.org, and found a bug when using bogus names in multi-mounts. The test case is:
/etc/auto.testing
foo -ro,hard,intr \ /dir/bar bogus:/usr/src \ /dir/baz morebogus:/usr/share/doc
When the function get_best_mount tries to resolve the bogus names, there is a host lookup failure. Then it returns the winner as local, and automount does a mount --bind. But the correct behaviour would be a mount failure.
The corresponding log entries follows attached. I have also made and tested a little patch to fix it (and a brace missing in autofs-4.1.4-multi-parse-fix.patch), that is attached as well.
Thank you very much for that. I will attend to it right now.
Ian
_______________________________________________ autofs mailing list autofs@linux.kernel.org http://linux.kernel.org/mailman/listinfo/autofs
