On Wed, 30 Nov 2005, Jeff Moyer wrote:

> ==> Regarding Re: [autofs] stat of /users/no-such-user takes 15 seconds; Ian 
> Kent <[EMAIL PROTECTED]> adds:
> 
> raven> On Tue, 29 Nov 2005, Jeff Moyer wrote:
> >> ==> Regarding Re: [autofs] stat of /users/no-such-user takes 15 seconds;
> >> Ian Kent <[EMAIL PROTECTED]> adds:
> >> 
> raven> On Tue, 22 Nov 2005, Jeff Moyer wrote:
> >> >> ==> Regarding Re: [autofs] stat of /users/no-such-user takes 15
> >> seconds; Ian Kent <[EMAIL PROTECTED]> adds:
> >> >> 
> >> 
> raven> Could you review this patch please Jeff.
> >> After reviewing this further, I did find a problem.  See below.
> 
> raven> All good points and the test is wrong.  I'll update the patch and
> raven> post another.
> 
> raven> That just leaves the re-read for the other cases which may be
> raven> causing a long delay. I'm not sure this slows the lookup unless
> raven> sending the signal is causing starvation of cpu cycles some
> raven> how. Perhaps the change from cache_add to cache_update will help
> raven> more than I think.
> 
> Ian,
> 
> The patch I'm attaching is the one against the RHEL autofs package.  This
> is what I have come up with, and it is WRONG.  =)  It causes a regression
> in the case where there are multiple keys of the same name in a map;  the
> patched automounter will always use the last key instead of the first.
> Remember dealing with this back in February?  Fun.
> 
> I'll keep poking at it, I just wanted to make you aware of the problem.

I'll check that when I make the patch but I'm fairly sure that I changed 
the cache code to prevent this at some point. If I can identify that I'll 
post it and specify it as a pre-patch. I also seem to remember that LDAP 
lookups were an issue and I still needed to deal with that.

Ian

_______________________________________________
autofs mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/autofs

Reply via email to