On Thu, 2007-10-11 at 15:43 +0200, Lukas Kolbe wrote:
> Hi Ian!
> Hi Mathias! Please see below why I think this might be important for you
> as well.
>  
> > > I *think* I understand what you describe there. If I were more
> > > knowledgeable about the internals of Linux and autofs I could be of more
> > > help :(
> > 
> > No matter, the point was only that this unexpected case needed to be
> > caught so I could send a mount request to the daemon. The VFS is quite a
> > complicated beast and I'm certainly no expert but have become familiar
> > with much of it, to some small extent, through working on autofs.
> 
> Must have bean painful ;)

Hahahah! but fun in itself. ;)

> 
>  
> > > Looks fairly simple - shall I test it even with your warning in the
> > > other mail?
> > 
> > Think so.
> 
> It didn't apply cleanly to 2.6.20 so I changed it manually. I just
> tested with only rebuilding the autofs4.ko-module and my kernel now
> thinks it's tainted (wtf...), BUT it works! I can't believe it! A
> one-liner, or, actually, a one-bitter ;)!

Odd, but no big problem.

> 
> I'm currently rebuilding the whole kernel so that I have a new .deb that
> I can roll out and test in a broader environment, but the exact use case
> of a recursive automount now seems to work perfectly well.
> Congratulations and thank you!

Keep an eye on expiration as well, make sure everything continues to
expire correctly, often times autofs will continue to work ok even when
it isn't quite expiring properly.

> 
> After testing, I'll push this forward to Ubuntu, but I don't have high
> hopes of it to be included in any update. It should definitly go into
> 2.6.24, I'll report back if it breaks anything else.

Ok, great, I'll keep testing myself and post it on LKML provided we
don't have any further problems.

> 
> If I understand this correctly, would this be the fix needed for the
> 'nested mounts with loop'-problem Mathias Koenig sees, as the problem
> seems to be quite a similar one as ours ...

Similar but not the same.

That particular issue takes a different path through the daemon and the
patch Mathias posted does fix the problem. I'll be committing something
very similar to the autofs repo and putting the patch on kernel.org
soonish.

Ian


_______________________________________________
autofs mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/autofs

Reply via email to