On Mon, 2011-06-13 at 18:39 -0300, Leonardo Chiquitto wrote: > Hello Ian, list > > While trying to make some progress on the AB/BA locking issue, I > think I've found a bug introduced by commit dc0c3734.
Committed, pushed and posted on kernel.org. Thanks Leonard. > > Thanks, > Leonardo > > > Remove master_mutex_unlock() leftover > > Commit dc0c3734 ("fix out of order locking in readmap") removes > the calls to master_mutex_lock() and master_mutex_unlock() from > master_find_mapent(), but leaves an unlock behind. > > Signed-off-by: Leonardo Chiquitto <lchiqui...@novell.com> > > --- > lib/master.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > Index: autofs/lib/master.c > =================================================================== > --- autofs.orig/lib/master.c > +++ autofs/lib/master.c > @@ -643,10 +643,8 @@ struct master_mapent *master_find_mapent > > entry = list_entry(p, struct master_mapent, list); > > - if (!strcmp(entry->path, path)) { > - master_mutex_unlock(); > + if (!strcmp(entry->path, path)) > return entry; > - } > } > > return NULL; > > _______________________________________________ > autofs mailing list > autofs@linux.kernel.org > http://linux.kernel.org/mailman/listinfo/autofs _______________________________________________ autofs mailing list autofs@linux.kernel.org http://linux.kernel.org/mailman/listinfo/autofs