Martin Koeppe wrote:
>> Thank you, Martin.  I'll change compat.h to read as follows:
>>
>> #if ! defined(HAVE_UINTPTR_T) && ! defined(uintptr_t)
>>  typedef unsigned long uintptr_t;
>> #endif
>>
> This would work. However, I think you could equally well remove those 3
> lines, as configure ensures that if HAVE_UINTPTR_T is not defined then
> always uintptr_t gets defined. And if the system should already #define
> uintptr_t as a macro, then HAVE_UINTPTR_T would be set, too, so the #if
> above is always false.

True.  I didn't do it only because I was certain of this variation
and I have to remember and consider all the contexts within which
this code gets built.

> But I think the typedef is nicer than a macro,

They are.  :)

> Similar typedefs should be written to compat/compat.h and removed from
> the end of config-h.in for mode_t, pid_t, scm_primitive_eval_x,
> scm_t_port, size_t, uid_t, wchar_t, wint_t.
> 
> Or if you prefer replacement macros, the HAVE_* macros aren't really
> needed, are they?, and should not be generated then at all.

Side effect of the autoconf testing.

> I think, however, that it is better to have the replacement types in
> compat.h, not in libopts.*.  configure should only detect what is there
> and what isn't, and compat.h decides what to do.

It is partly an issue of the amount of playtime I have.
If you were kind enough to put together a patch that did this,
I'd then check it to ensure that everything was still working
and add it to the source base, with grateful appreciation.

Cheers - Bruce

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Autogen-users mailing list
Autogen-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/autogen-users

Reply via email to