On 06/07/2012 11:52 AM, Akim Demaille wrote:
>
> Le 6 juin 2012 à 18:15, Stefano Lattarini a écrit :
>
>> +* Diagnostic about possible typos in '_SOURCES', '_LIBADD, '_LDFLAGS',
>> + '_LDADD' and '_DEPENDENCIES' variables is now done at make runtime
>> + rather than at automake runtime. In case some (or all) such diagnostic
>> + is undesired, it can be silenced by adding the affected variables to
>> + the 'AM_VARTYPOS_WHITELIST' variable, as in:
>> +
>> + bin_PROGRAMS = cp mv
>> + copy_LDADD = -lselinux -lrt -acl
>> + cp_LDADD = $(copy_LDADD)
>> + mv_LDADD = $(copy_LDADD)
>> + # Without this, the generated Makefile would complain that
>> + # no program or library has 'copy' as canonical name.
>> + AM_VARTYPOS_WHITELIST = copy_LDADD
>
> I understand why this is nice looking (to use copy_LDADD), but
> really, wouldn't it be saner to just some other name? Say
> copy_ldadd.
>
Probably yes, but coreutils is actually using $(copy_LDADD) today, and
I'd like to avoid forcing too much code churn on our client packages
whenever possible, at least when it is (like in this case) easy and
natural to do so. Moreover, as I wrote in the commit message of the
first patch:
Such a whitelisting capability is a good idea even regardless this
motivation, since it helps enforcing the Autotools- philosophy
"the user is always right" (as long as he is explicit enough).
Don't you agree with my rationales?
Regards,
Stefano
