Hi Akim. On 07/27/2012 10:54 AM, Akim Demaille wrote: > > Le 27 juil. 2012 à 10:39, Stefano Lattarini a écrit : > >> * lib/am/header-vars.am (DESTDIR): It's not because we want to allow > > I guess s/not//. > Oops, fixed.
>> it to be defined from the environment, for compatibility with mainline >> Automake. For better clarity, define an (empty) default with the line >> "DESTDIR ?=", instead that with the commend-out definition "# DESTDIR=". > > commented. > > instead of > Ditto. >> -## We used to define this. However, we don't because vendor makes >> -## (e.g., Solaris, Irix) won't correctly propagate variables that are >> -## defined in Makefile. This particular variable can't be correctly >> -## defined by configure (at least, not the current configure), so we >> -## simply avoid defining it to allow the user to use this feature with >> -## a vendor make. >> -## DESTDIR = >> +# We want ithis to be overridable from the environment, for better > > this > Ditto. >> +# compatibility with mainline Automake. >> +DESTDIR ?= > > Yet I think "We want" is too verbose in general. "Make it overridable…", > or "Be overridable…", or even "Overridable…" is better IMHO. > OK. Thanks, Stefano
