On 07/30/2012 09:30 AM, Akim Demaille wrote: > > Le 28 juil. 2012 à 02:22, Stefano Lattarini a écrit : > >> -define am.test-suite.handle-suffix >> - >> -ifeq ($$(call am.vars.is-undef,$$(call am__tpfx,$1)LOG_DRIVER),yes) >> -$$(call am__tpfx,$1)LOG_DRIVER = $(SHELL) $(am.conf.aux-dir)/test-driver >> +define am.test-suite.handle-suffix.helper >> +ifeq ($$(call am.vars.is-undef,$(2)LOG_DRIVER),yes) > > It looks like some comments to document the arguments > would be useful. > I didn't consider that necessary because the one and only use of thus helper function is few lines below, so the nature of the $2 argument becomes clear from the context. Still, if you have a comment to suggest, I'll gladly add it in a follow-up patch.
>> +$(2)LOG_DRIVER = $(SHELL) $(am.conf.aux-dir)/test-driver >> endif > > >> - >> -%.log %.trs: %$1 $$($$(call am__tpfx,$1)LOG_DEPENDENCIES) >> - @$$(call am.test-suite.runtest,$$(call am__tpfx,$1)) >> - >> +%.log %.trs: %$1 $$($(2)LOG_DEPENDENCIES) >> + @$$(call am.test-suite.runtest,$2) >> ifeq ($(am.conf.handle-exeext),yes) >> ifdef EXEEXT >> -%.log %.trs: %$1$(EXEEXT) $$($$(call am__tpfx,$1)LOG_DEPENDENCIES) >> - @$$(call am.test-suite.runtest,$$(call am__tpfx,$1)) >> +%.log %.trs: %$1$(EXEEXT) $$($(2)LOG_DEPENDENCIES) >> + @$$(call am.test-suite.runtest,$2) >> endif # defined EXEEXT >> endif # am.conf.handle-exeext = yes >> +endef >> >> -endef # am.test-suite.handle-suffix >> +define am.test-suite.handle-suffix >> +$(call $0.helper,$1,$(if $1,$(call am.util.toupper,$(patsubst .%,%_,$1)))) >> +endef >> >> ifeq ($(call am.vars.is-undef,TEST_EXTENSIONS),yes) >> TEST_EXTENSIONS := .test Thanks, Stefano
