Hi Eric, On Fri, March 21, 2008 14:02, Eric Blake wrote: > Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes: > >> Comments, reviews appreciated. > > Looks like a good idea. Sorry for the delayed review.
Hey, it's great to have review at all, no matter how delayed. >> @@ -4881,6 +4889,9 @@ sub scan_autoconf_traces ($) >> AM_MAINTAINER_MODE => 0, >> AM_PROG_CC_C_O => 0, >> _AM_SUBST_NOTMAKE => 1, >> + _AM_COND_IF => 1, >> + _AM_COND_ELSE => 1, >> + _AM_COND_ENDIF => 1, > > Based on your question about trace order, should this section be modified > to take macro invocation depth into account to work around underquoted > usage? Do you have a specific solution in mind? At the time I wrote this I didn't see one, but then I wasn't aware that underquotation would be a problem. I'll deal with the rest of your good remarks when I have decent net access again. Thanks, Ralf
