Hi Eric, * Eric Blake wrote on Thu, Apr 10, 2008 at 05:59:13PM CEST: > Automake should set a good example of proper macro quoting. Expanding > AC_AUTOCONF_VERSION is dangerous, since snapshot versions of autoconf include > letters in the version string, which in turn could expand as inadvertent > macros. Is this okay to apply, as well as cherry-pick back to branch-1-10?
Yep. FWIW, over here the patch is mangled in a way such that both git am and git apply reject it, so I didn't test it. > Meanwhile, now that Autoconf 2.62 is released, is it time to regenerate all > the > generated files in the automake repository with 2.62 rather than an autoconf > snapshot? Yep, please do this right alongside with the patch (no need to mention the generated files in the ChangeLog entry). Thank you, Ralf > Subject: [PATCH] AC_AUTOCONF_VERSION can inadvertently expand to a macro name. > > * m4/amversion.in (AM_SET_CURRENT_AUTOMAKE_VERSION): Use proper > m4 quoting. > * aclocal.in (write_aclocal): Likewise. > * tests/missing6.test: New test. > * tests/Makefile.am (TESTS): Run it. > * tests/missing4.test: Adjust.
