Avoid possible false negatives in confh5.test. * tests/confh5.test: Enable shell `errexit' flag, and bumped copyright years. Due to this change, any unexpected failure in calls to $ACLOCAL, $AUTOMAKE, $AUTOCONF or $AUTOHEADER, or a failure in grepping expected text in output files should now cause the whole test to fail.
No portability problems should be introduced, since the test script uses only simple commands (no compuond commands, no shell functions, no shell control structures). Thus the global use of the `errexit' shell flag should be safe also on more "exotic" shells (unless they are severely broken).
From 51b5a03e37559d437da008e775605a10471cc8e4 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Fri, 9 Apr 2010 16:33:43 +0200 Subject: [PATCH 1/2] Avoid possible false negatives in confh5.test. * tests/confh5.test: Enable shell `errexit' flag, and bumped copyright years. Due to this change, any unexpected failure in calls to $ACLOCAL, $AUTOMAKE, $AUTOCONF or $AUTOHEADER, or a failure in grepping expected text in output files should now cause the whole test to fail. No portability problems should be introduced, since the test script uses only simple commands (no compuond commands, no shell functions, no shell control structures). Thus the global use of the `errexit' shell flag should be safe also on more "exotic" shells (unless they are severely broken). --- ChangeLog | 9 +++++++++ tests/confh5.test | 4 +++- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index a5b5426..27da4aa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2010-04-09 Stefano Lattarini <stefano.lattar...@gmail.com> + + Avoid possible false negatives in confh5.test. + * tests/confh5.test: Enable shell `errexit' flag, and bumped + copyright years. Due to this change, any unexpected failure + in calls to $ACLOCAL, $AUTOMAKE, $AUTOCONF or $AUTOHEADER, or + a failure in grepping expected text in output files should now + cause the whole test to fail. + 2010-04-04 Stefano Lattarini <stefano.lattar...@gmail.com> Generated tests are now just a thin layer around other tests. diff --git a/tests/confh5.test b/tests/confh5.test index 15593c8..c81f3a3 100755 --- a/tests/confh5.test +++ b/tests/confh5.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2003 Free Software Foundation, Inc. +# Copyright (C) 2003, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,6 +18,8 @@ . ./defs || Exit 1 +set -e + cat >> configure.in << 'END' AC_SUBST([FOO], [name]) AC_CONFIG_FILES(include/config.h.in) -- 1.6.5
