Hi Jim. While I don't feel qualified to discuss the merits of the matter here, I have a couple of nits below...
On Monday 04 October 2010, Jim Meyering wrote: > > From d2c29e15a77ab2a073cf64919ab320bfec001833 Mon Sep 17 00:00:00 > 2001 From: Jim Meyering <[email protected]> > Date: Sat, 2 Oct 2010 22:30:02 +0200 > Subject: [PATCH] dist-xz: don't hard-code -9: honor setting of > XZ_OPT > > * lib/am/distdir.am (dist-xz): Do not hard-code xz's -9: that > made it impossible to override. Instead, use its XZ_OPT envvar, > defaulting to -9 if not defined. Thus no change in behavior > when XZ_OPT is not set, and now, this rule honors the setting > of that envvar when it is set. Suggested by Lasse Collin. > * NEWS (Miscellaneous changes): Mention it. > * doc/automake.texi (The Types of Distributions): Describe the > newly enabled environment variables. > --- > Makefile.in | 6 ++++-- > NEWS | 5 +++++ > aclocal.m4 | 4 ++-- > configure | 10 +++++----- > doc/automake.texi | 7 +++++++ > lib/am/distdir.am | 6 ++++-- > 6 files changed, 27 insertions(+), 11 deletions(-) > > diff --git a/Makefile.in b/Makefile.in > index 232fbf7..194b784 100644 > --- a/Makefile.in > +++ b/Makefile.in > @@ -651,7 +651,8 @@ dist-gzip: distdir > tardir=$(distdir) && $(am__tar) | GZIP=$(GZIP_ENV) gzip -c > $(distdir).tar.gz $(am__post_remove_distdir) > dist-bzip2: distdir > - tardir=$(distdir) && $(am__tar) | bzip2 -9 -c >$(distdir).tar.bz2 > + tardir=$(distdir) && $(am__tar) \ > + | BZIP2=${BZIP2--9} bzip2 -c >$(distdir).tar.bz2 Typo here: should be "$${BZIP2--9}". But then: why not follow consistently the example of the gzip compression? As in: GZIP=$(GZIP_ENV) gzip -c >$(distdir).tar.gz with GZIP_ENV set to a proper default in the generated makefile, and overridable through the command line: $ make dist GZIP_ENV=--fast > diff --git a/aclocal.m4 b/aclocal.m4 > index c43a368..4a22182 100644 > --- a/aclocal.m4 > +++ b/aclocal.m4 Why have you regenerated this file with a unreleased autoconf version? > diff --git a/configure > b/configure > index 169d82d..2940276 100755 > --- a/configure > +++ b/configure Ditto. > diff --git a/doc/automake.texi b/doc/automake.texi > index 22c2f27..0652aa8 100644 > --- a/doc/automake.texi > +++ b/doc/automake.texi > @@ -8461,6 +8461,9 @@ The Types of Distributions > @item @code{dist-bzip2} > Generate a bzip2 tar archive of the distribution. bzip2 archives > are frequently smaller than gzipped archives. > +By default, this rule makes @samp{bzip2} use a compression option > of @option{-9}. +To make it use a different one, set the > @env{XZ_OPT} environment variable BZIP2 environment variable > +For example, @samp{make dist-bzip2 XZ_OPT=-7}. Ditto. Thanks, Stefano
