On Monday 15 November 2010, Peter Rosin wrote:
> Den 2010-11-15 09:19 skrev Peter Rosin:
> > diff --git a/tests/defs b/tests/defs
> > index 82c3b5b..e37bb96 100644
> > --- a/tests/defs
> > +++ b/tests/defs
> > @@ -290,6 +290,15 @@ do
> > echo "$me: running texi2dvi -o /dev/null --version"
> > ( texi2dvi -o /dev/null --version ) || exit 77
> > ;;
> > + xsi-shell)
> > + # Try some XSI features.
> > + echo "$me: trying some XSI constructs"
> > + ( _am_dummy="a/b/c"
> > + test
> > "${_am_dummy##*/},${_am_dummy%/*},${_am_dummy#??}"${_am_dummy%"$_am_dummy"},
> > \
> > + = c,a/b,b/c, \
> > + && eval 'test $(( 1 + 1 )) -eq 2 \
> > + && test "${#_am_dummy}" -eq 5' ) >/dev/null 2>&1 || exit 77
>
> The ">/dev/null 2>&1" part should probably be removed.
I agree. Let the user/developer know in detail why the test was skipped.
And in another mail:
> This is based off of master (but I guess it also applies to tests-init)
I guess so to, and I'd prefer it to be applied there (tests-init is
routinely merged to master anyway).
Thanks for the patch,
Stefano
