On Monday 13 December 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Dec 11, 2010 at 06:41:46PM CET: > > Ping on this? Reference: > > <http://lists.gnu.org/archive/html/automake-patches/2010-09/msg00106.html> > > > > The updated patch is attached. I will push it in 72 hours (by tuesday > > evening) unless there are objections. > > OK but ... > > > --- /dev/null > > +++ b/tests/canon8.test > > @@ -0,0 +1,39 @@ > > > +grep foob.rquux Makefile.in # might be useful for debugging > > +grep f...@rquux Makefile.in # `@' must not be transliterated ... > > +grep 'foo...@]rquux' Makefile.in && Exit 1 # ... ever! > > ... these last two lines look scary: unbalanced backticks and > exclamation mark in commands. I know that that they are not special in > comments, but the latter are special on the command line, and I don't > like surprises when cut and pasting commands from a script. > Those comments aren't really that useful anyway; I squashed in the following diff:
-*-*-*- diff --git a/tests/canon8.test b/tests/canon8.test index 0bd3bf8..2ae47dd 100755 --- a/tests/canon8.test +++ b/tests/canon8.test @@ -32,8 +32,9 @@ END $ACLOCAL $AUTOMAKE -grep foob.rquux Makefile.in # might be useful for debugging -grep f...@rquux Makefile.in # `@' must not be transliterated ... -grep 'foo...@]rquux' Makefile.in && Exit 1 # ... ever! +# The first grep is here mostly for debugging. +grep foob.rquux Makefile.in +grep f...@rquux Makefile.in +grep 'foo...@]rquux' Makefile.in && Exit 1 : -*-*-*- Will push by tomorrow if you don't object. > Please avoid such inline comments, also because they hurt the > eye, IMVHO. > Weird, I often find them visually appealing. Taste is a strange beast, isn't it? ;-) Thanks, Stefano