On Saturday 08 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Fri, Jan 07, 2011 at 11:50:51PM CET: > > Subject: [PATCH 2/2] yacc: support variable expansions in *YFLAGS > > definition. > > > > This commit fixes automake bug#7800. > > OK with nits addressed. > > Thanks! > Ralf > > > * automake.in (lang_yacc_target_hook): Use 'value_as_list_recursive' > > instead of 'variable_value' to get the value of *YFLAGS variables. > > Related changes. > > ($DASH_D_PATTERN): Removed as obsolete. > > Just "Removed." is sufficient. There is nothing obsolete about this, > this is not public API, and it is merely unneeded now. > Agreed; fixed.
> > * tests/Makefile.am (XFAIL_TESTS): Remove yflags-var-expand.test. > > * tests/yacc-clean.test: Remove a now-useless workaround. > > Strictly speaking, "useless" is not the correct description here. > It is simply not needed any more. I'd just write "Remove workaround." > but I am aware that I'm far off into picky picky land here already ... > I went for "Remove workaround for now-fixed bug". OK? > > * NEWS: Update. > > > --- a/NEWS > > +++ b/NEWS > > @@ -56,6 +56,12 @@ Bugs fixed in 1.11.0a: > > - The code for automatic dependency tracking works around a Solaris > > make bug triggered by sources containing repeated slashes when the > > `subdir-objects' option was used. > > + > > + - Automake is now smart enough to detect the presence of the `-d' flag > > Let's not brag: s/is now smart enough to detect/now detects/ > OK (I didn't intend to brag, BTW). -*-*- Will push tomorrow if there are no further remarks. Thanks, Stefano