Hello Ralf. There's still a wart to be fixed before this patch series can be committed ...
On Thursday 13 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Wed, Jan 12, 2011 at 09:11:41PM CET: > > On Wednesday 12 January 2011, Ralf Wildenhues wrote: > > > So, now with that said, I'm not sure whether I should approve this > > > patch. What do you think? > > > > > I think that you should, provided that I add the sanity check you > > suggested above. > > OK. > Hmm... Wait, this sanity check is OK only starting from [PATCH 7/9] onward, as until then the 'handle_options()' subroutine still calls 'process_option_list()' multiple times (that's why the bug is still present for AUTOMAKE_OPTIONS at this point). So, OK to add the sanity check in [PATCH 7/9] (or in a new follow-up patch to be placed between patches 7 and 8 in this series)? Regards, Stefano
