Stefano Lattarini wrote: > Hello automakers. Resuming an old thread ... > > Reference: > <http://lists.gnu.org/archive/html/automake-patches/2011-01/msg00192.html> > > On Monday 17 January 2011, Ralf Wildenhues wrote: >> [ Cc:ing Jim because of ideas at the end ] >> > And CC:ing him again because I'd like an ACK from him (see below). > >> * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: >> > This patch stemmed from this discussion: >> > <http://lists.gnu.org/archive/html/automake-patches/2011-01/msg00144.html> >> > >> > I'd like to have the patch applied to maint, to make eventual integration >> > of new tests easier. But the follow-up patches converting the testsuite >> > to the use of skip_() and providing more informative messages for skipped >> > tests should go to master only, to avoid unecessary "merging churn". >> > >> > OK? >> >> Unfortunately not, for a couple of reasons. I'm sorry I didn't think >> about it in more depth before, but there are several things that I think >> could be better with this patch. >> >> First off, a legal one, quoting maintain.info: >> >> When you copy legally significant code from another free software >> package with a GPL-compatible license, you should look in the package's >> records to find out the authors of the part you are copying, and list >> them as the contributors of the code that you copied. If all you did >> was copy it, not write it, then for copyright purposes you are _not_ >> one of the contributors of _this_ code. >> >> So, if we copy the code, then Jim is the author of it. >> > OK, I've added Jim as the primary author of this patch (both in the > ChangeLog and with "git --author"). I'll wait his ACK on this attribution > before pushing.
Hi Stefano, Thanks for the heads-up. That looks fine, though I haven't tested it. I'm glad you listed yourself as co-author. ... > The updated patch is attached; when I got Jim ACK, I'll push it to maint, > to make eventual integration of new testcases using the new subroutines > easier (and because the patch is really non-invasive). I'll follow-up > soonish with patches converting the testsuite to the use of skip_() and > of more informative skip messages; this patches will be applied to a new > temporary public branch "testsuite-work", meant to be finally merged into > master (once it's stabilized). > From 2c8b68396a48f70de2856f0747968225f4906abf Mon Sep 17 00:00:00 2001 > From: Jim Meyering <meyer...@redhat.com> > Date: Sun, 16 Jan 2011 15:36:07 +0100 > Subject: [PATCH] tests: new subroutines for test skipping/failing. > > * tests/defs.in (Exit): Move definition of this function earlier. > (warn_, skip_, fail_, framework_failure_): New functions, inspired > to the homonyms in gnulib's tests/init.sh. > ($stderr_fileno_): New global variable, used by the new functions > above. > * tests/README: Updated. > > From a suggestion by Ralf Wildenhues. ... > +2011-04-23 Jim Meyering <meyer...@redhat.com> > + Stefano Lattarini <stefano.lattar...@gmail.com> > + > + test defs: new subroutines for test skipping/failing > + * tests/defs.in (Exit): Move definition of this function earlier. > + (warn_, skip_, fail_, framework_failure_): New functions, inspired > + to the homonyms in gnulib's tests/init.sh. > + ($stderr_fileno_): New global variable, used by the new functions > + above. > + * tests/README: Updated. > + From a suggestion by Ralf Wildenhues.
