Den 2011-09-12 11:16 skrev Stefano Lattarini: > The python-work branch contains very minimal refactorings, improvements > and testsuite enhancements for the Automake python support. IMHO it could > safely merged back into maint. Here is the commits that would be merged: > > b46debf python: run the 'py-compile' script with $(SHELL) > dd8b570 py-compile: the '--destdir' option now accepts a blank argument > a716df2 python tests: add "unit tests" on py-compile > 429b748 py-compile: normalize error and help messages > cd16ceb py-compile: complain on unrecognized options > a2ebf0e py-compile: '--' and non-option arguments terminate the option list > > Attached is the result of "git diff maint python-work", for reference. > > I will proceed with the merge in a couple of days if there are no > objections.
While I did not look at any of the code, I did read through the text parts of the diff. Below are the nits I found. Cheers, Peter > diff --git a/NEWS b/NEWS ... > + Moreover, a non-option argument or a special `--' arguments terminates > + the list of options. argument > diff --git a/tests/py-compile-basedir.test b/tests/py-compile-basedir.test ... > +# We'll need to create files in `..', so that we need another level of > +# subdirectory in order not to clutter up the top-level tests directory. ..., so we need one more subdirectory level in order... > diff --git a/tests/py-compile-basic.test b/tests/py-compile-basic.test ... > +cat > foo.py <<'END' > +# Try out some non-trivial sytanx in here. syntax > +cat > bar.py <<'END' > +# Import of non-existent modules, or assertion of flase conditions, false > diff --git a/tests/py-compile-option-terminate.test > b/tests/py-compile-option-terminate.test ... > +# Check that a `--' argument explicitly terminates option list for terminates the option list
