On 01/27/2012 05:43 PM, Peter Rosin wrote:
> Stefano Lattarini skrev 2012-01-27 17:16:
>> On 01/27/2012 03:18 PM, Peter Rosin wrote:
> *snip*
>>> And here's from Cygwin "1.7.10s(0.259/5/3) 20120123" (latest snapshot, with
>>> release candidate "quality", 1.7.10 is coming RSN, as they say).
>>>
>>> lzma.test fails for the same reason as above in MinGW,
>>>
>> Maybe it would be nice to start working around this before the release,
>> by exporting "XZ_DEFAULTS=--memlimit=150MiB" in the environment?  If yes,
>> extra points to whoever beats me at doing so ;-)
> 
> I'm not bothered enough, sorry, and there should be a way for the user
> to override in case 150MiB (or whatever we select) is not appropriate, so
> some care has to be taken...
>
Well, the lzma compression has been deprecated in favour of xz/lzip already,
and the lzma support will be removed in automake 1.12 anyway; so I say we
stop worrying about this issue until we see a bug report from a "real world"
user, OK?

> What I don't get is what the f/#ยค they are doing stumbling over memory
> issues when compressing what could best be described as tiny files, at
> least compared to the memory that is available.  Crappy.
>
>>> and transform2.test is an old known failure.
>>>
>> Has this already been reported in details and/or analysed?
> 
> There's this:
> http://lists.gnu.org/archive/html/automake-patches/2010-08/msg00097.html
>
Thanks for the link.  What do you think of the workaround provided by the
attached patch?  Good to go before 1.11.3?

>>> JFTR, my TeX install has been corrected with a tiny
>>> patch (that has been mentioned previously on the Automake lists).
>>>
>> And I seem to recall you had reported the issue upstream to the Cygwin
>> list as well ...  Hasn't it been fixed yet?
> 
> Nope, not that I know of.  Perhaps time for a ping...
> http://cygwin.com/ml/cygwin/2011-11/msg00393.html
> 

Thanks,
  Stefano
>From 4c7eef3bf2e364de6af1bd57029d27bce92145a3 Mon Sep 17 00:00:00 2001
Message-Id: <4c7eef3bf2e364de6af1bd57029d27bce92145a3.1327685813.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <[email protected]>
Date: Fri, 27 Jan 2012 18:35:28 +0100
Subject: [PATCH] tests: avoid spurious failure of on Cygwin of
 'transform2.test'

On newer Cygwin versions (at least 1.7.x), the 'transform2.test'
has been failing spuriously; the gist is the following: some
*purposefully* rigged install rules there tries something like:

  install bla.exe .../inst/bin/foo.exe
  install script.sh .../inst/bin/foo

and the second install command fails (trying to overwrite the
'foo.exe', likely due to overly aggressive appending of '.exe'
suffix when copying/renaming Windows executables).  Since this
is a Cygwin issue rather than an Automake one (and since the use
case we are testing is a really corner-case anyway, making it
unworthy to attempt to work around it in automake proper), we
simply hack the test case to avoid the failure.

Analysis by Peter Rosin and Ralf Wildenhues.

References:
<http://lists.gnu.org/archive/html/automake-patches/2010-08/msg00153.html>
<http://thread.gmane.org/gmane.os.cygwin/119380>

* tests/transform2.test: Skip the affected part of the test if the
described Cygwin behaviour is detected.
---
 tests/transform2.test |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/tests/transform2.test b/tests/transform2.test
index 0f9d5ec..07943bc 100755
--- a/tests/transform2.test
+++ b/tests/transform2.test
@@ -1,5 +1,6 @@
 #! /bin/sh
-# Copyright (C) 2002, 2003, 2004, 2007, 2008  Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003, 2004, 2007, 2008, 2012 Free Software
+# Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -74,9 +75,23 @@ $MAKE uninstall
 test `find inst -type f -print | wc -l` = 0
 
 # Also squash all file types in question.
+
+# On newer Cygwin versions, that won't work, likely due to overly
+# aggressive appending of '.exe' suffix when copying/renaming Windows
+# executables).  So let's skip this part of the test if we detect the
+# faulty heuristic is present.  See also:
+# <http://lists.gnu.org/archive/html/automake-patches/2010-08/msg00153.html>
+# <http://thread.gmane.org/gmane.os.cygwin/119380>
+echo Foo > foo
+echo Bar > bar.exe
+chmod a+x foo bar.exe
+cp foo bar && cmp foo bar \
+  || skip_ "your Cygwin is too aggressive in tweaking '.exe' suffixes"
+
 ./configure --program-transform-name='s/.*/foo/' --prefix "`pwd`/inst" --mandir "`pwd`/inst/man"
 $MAKE
 $MAKE test-install-foo
 $MAKE uninstall
 test `find inst -type f -print | wc -l` = 0
+
 :
-- 
1.7.7.3

Reply via email to