On 07/27/2012 01:28 AM, Yu Mingfei wrote:
+def virsh_list(option="--all", uri = ""):
+ """
+ - list domains -
+ @param option: Can take various values see 'virsh help list'
+ for more details.
+ @param uri : connect uri
+
+ Returns a list :
+ Returns dictionary with each entry
+ as :<'dom-name'>: [<dom-id> ,<dom-status> ]
+
+ """
Hi Lucas:
I need to test virsh list.
Since this function just return output of virsh list,
I can not get status from this function.
I have sent a same name function of virsh_list in my virsh list patchset.
Do you have some idea about this problem?
Should I move my virsh_list to my test file virsh_list.py?
Not necessary to duplicate code, but we do need low-level functions to
be generally usable by everyone. These types of conflicts are inevitable
with multiple teams working on same code.
I connected with lmr and he said all virsh_list() proposals were sent
back for re-working. My preference is to pick the first virsh_list()
that's most simple, "good enough", complete, and "fits" well within the
code. If it needs to be enhanced/extended for other uses later, then so
be it.
Perhaps send the virsh_list() patch proposals separately/stand-alone?
I'm guessing lots of other code depends on it anyway.
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
