On 07/26/2012 04:32 PM, Lucas Meneghel Rodrigues wrote:
On Thu, Jul 26, 2012 at 5:20 PM, Lucas Meneghel Rodrigues
+ def managedsave(self, options="", ignore_status=False, print_info=False):
...
^ Ok, here is my entire objection against this patch. There's no need
to add a public interface to the vm class, as managedsave is more of a
management general function. So instead just call the virsh function
in the test rather than vm.managedsave. So please send another version
of this patchset with this fixed.
Thanks for your work,
Lucas
Just as FYI, a good rule-of-thumb here is: If the functionality will be
used by 3 or more test modules, then it's okay to put as a vm method.
Otherwise, just leave it as special-case code inside a test. Otherwise
we end up with many many many vm methods to maintain :)
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
