This patch adds a function to ElementTree: remove().
It can remove a subelement with given element name.
And this patch adds a libvirt_xml to virt, to put some operations of libvirt
xml.
Signed-off-by: Yu Mingfei <[email protected]>
---
client/shared/ElementTree.py | 10 ++++++++++
client/virt/libvirt_xml.py | 42 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 0 deletions(-)
create mode 100644 client/virt/libvirt_xml.py
diff --git a/client/shared/ElementTree.py b/client/shared/ElementTree.py
index 7dbc72e..50c1d82 100644
--- a/client/shared/ElementTree.py
+++ b/client/shared/ElementTree.py
@@ -647,6 +647,16 @@ class ElementTree:
return self._root.findall(path)
##
+ # Removes a matching subelement.
+ #
+ # @param element is What to be removed.
+ # @return a new element tree.
+
+ def remove(self, element):
+ assert self._root is not None
+ return self._root.remove(element)
+
+ ##
# Writes the element tree to a file, as XML.
#
# @param file A file name, or a file object opened for writing.
diff --git a/client/virt/libvirt_xml.py b/client/virt/libvirt_xml.py
new file mode 100644
index 0000000..79a1382
--- /dev/null
+++ b/client/virt/libvirt_xml.py
@@ -0,0 +1,42 @@
+import logging, os.path
+from autotest.client.shared import error, xml_utils
+from autotest.client.virt import libvirt_vm as virsh
+
+class LibvirtXMLError(Exception):
+ pass
+
+class LibvirtXMLVMNameError(LibvirtXMLError):
+ pass
+
+class LibvirtXML(xml_utils.XMLBase):
+ pass
+
+def vm_rename(name, new_name, uri=""):
+ """
+ Rename a vm within libvirt
+
+ @param name: The current name for the vm.
+ @param new_name: The new name for the vm.
+ """
+ if name == new_name or virsh.virsh_domain_exists(new_name, uri):
+ raise LibvirtXMLVMNameError("Cannot rename a VM to an existing name")
+
+ # Two xml files to define and undefine
+ old_vm_xml = "/tmp/old_vm.xml"
+ new_vm_xml = "/tmp/new_vm.xml"
+ virsh.virsh_dumpxml(name, to_file=old_vm_xml, uri=uri)
+ vm_xml = LibvirtXML(old_vm_xml)
+ vm_xml.find('name').text = new_name
+ vm_xml.remove(vm_xml.find('uuid'))
+ vm_xml.write(new_vm_xml)
+
+ if not virsh.virsh_undefine(name, uri):
+ logging.error("Undefine %s failed.", name)
+ # backup and temporary files removed automatically
+ raise LibvirtXMLVMNameError("Failed to remove VM for renaming")
+ if not virsh.virsh_define(new_vm_xml, uri):
+ if not virsh.virsh_define(old_vm_xml):
+ raise LibvirtXMLVMNameError("Failed to restore original VM on "
+ "rename exception.")
+ raise LibvirtXMLVMNameError("Failed to define renamed vm from XML")
+ logging.debug("Sucessfully renamed %s to %s.", name, new_name)
--
1.7.1
--
Best Regards
Yu Mingfei
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
