On 07/31/2012 12:11 AM, Chris Evich wrote:
This is the simpelest of the two options I can think of for moving all the
libvirt_vm.virsh_*() functions into their own module. This is required
in order to prevent circular dependencies when the planned libvirt_xml
module is implimented later. It's also the least likely to cause
major headaches with third-party tests/code.
The alternative, IMHO is more user-friendly and has a better 'feel'. It
involves removing all the 'virsh_' prefixes from the names. i.e. it
allows callers to use virsh.cmd() instead of virsh.virsh_cmd() or resort
to the less-preferred 'from autotest.client.virt.virsh import *'.
Please give feedback if you like what this patch does, or if you feel the more
user-friendly alternative is better (or if you have another idea).
Nice job, I like it. The only question is whether we want to organize
all of virsh_*() functions
via a VIRSH class, you know each virsh_*() includes a 'uri' parameter,
maybe, we may instantiate
it in the VIRSH class.
Thanks.
Chris Evich (2):
virt: Move virsh_*() to dedicated module
virt: migrate libvirt.virsh_*() to virsh_*()
client/tests/libvirt/tests/virsh_freecell.py | 3 +-
client/tests/libvirt/tests/virsh_migrate.py | 11 +-
client/tests/libvirt/tests/virsh_nodeinfo.py | 3 +-
client/tests/libvirt/tests/virsh_vcpupin.py | 5 +-
client/virt/libvirt_monitor.py | 324 ----------------
client/virt/libvirt_vm.py | 513 +-------------------------
client/virt/virsh.py | 519 ++++++++++++++++++++++++++
7 files changed, 533 insertions(+), 845 deletions(-)
delete mode 100644 client/virt/libvirt_monitor.py
create mode 100644 client/virt/virsh.py
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
