Hi Lucas First Thank you :) When my first patch has be accepted, I just want to say thank you from my heart.
But I think two of my patches about copy src and copy patch files, you have made some globe changes are more better than my solution, my patches actually had shortcomings ,that's why I sent you a email to discuss with you. But I think my patch about ffsb, also changed the code in appropriate method (setup), as you know in many test cases codes,use method "system" or "run" to exec the external command. OK,as a newer,I will try my best to send more patches to the community. If my patch has shortcomings I wish you can give me some comments and advice:) Thanks Mike 在 2012-08-01三的 11:17 -0300，Lucas Meneghel Rodrigues写道： > On Wed, Aug 1, 2012 at 3:19 AM, Mike <[email protected]> wrote: > > Hi Lucas, > > I think you may not see my patches,I have sent, > > > > to try to fix this bug and other two.Though some of my patch may not > > good enough,see : > > I saw your patches Mike, but I believe most of them had shortcomings, > so as this was a fairly serious problem, I rushed to fix them more > properly, which resulted in the patches I've sent. > > I'm sorry if that sounded impolite, it was not my intention. Thanks > for the patches, and I hope you keep working and sending patches to > us. I've accepted one of the patches you've sent and properly notified > you. > > Thanks, > > Lucas > > > 1.[Autotest] [PATCH] Fix ffsb with no such file profile.cfg in parent > > directory of srcdir > > https://www.redhat.com/archives/autotest-kernel/2012-July/msg00078.html > > > > > > 2. [Autotest] [PATCH] Fix patch file not found in parent dir of srcdir > > https://www.redhat.com/archives/autotest-kernel/2012-July/msg00076.html > > > > > > 3.[Autotest] [PATCH] Fix src path of hackbench > > https://www.redhat.com/archives/autotest-kernel/2012-July/msg00077.html > > > > > > 在 2012-07-31二的 10:45 -0300，Lucas Meneghel Rodrigues写道： > >> Recently we've changed the test modules to be 'read only', > >> that is, we don't want anything to write to the test modules > >> dir, since autotest might be installed on a system wide > >> location. However, some autotest tests do have source > >> code directories on them, and currently they'll fail to > >> run, since now test.srcdir points to a different directory. > >> > >> So verify whether the source code dir 'src' exists inside > >> the test module dir, if so, copy the source contents to > >> the test.srcdir temporary directory. > >> > >> This patch fixes a bug where tests such as hackbench, > >> aio_dio_bugs and others were failing to run. > >> > >> Signed-off-by: Lucas Meneghel Rodrigues <[email protected]> > >> --- > >> client/shared/test.py | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/client/shared/test.py b/client/shared/test.py > >> index 8012087..4d98380 100644 > >> --- a/client/shared/test.py > >> +++ b/client/shared/test.py > >> @@ -53,6 +53,10 @@ class base_test(object): > >> default=tmpdir) > >> self.srcdir = os.path.join(output_config, > >> os.path.basename(self.bindir), > >> 'src') > >> + source_code_dir = os.path.join(self.bindir, 'src') > >> + if os.path.isdir(source_code_dir): > >> + if not os.path.isdir(self.srcdir): > >> + shutil.copytree(source_code_dir, self.srcdir) > >> if not os.path.isdir(self.srcdir): > >> os.makedirs(self.srcdir) > >> self.tmpdir = tempfile.mkdtemp("_" + self.tagged_testname, > > > > > > _______________________________________________ > > Autotest-kernel mailing list > > [email protected] > > https://www.redhat.com/mailman/listinfo/autotest-kernel > > > _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
