On Thu, 2012-08-02 at 11:22 +0800, Mike wrote: > Hi Lucas > > This three patches is to move the download cache dir to tmp, to keep no > changes in test case dir. > > I think another way to fix it,is to change it in method > unmap_url_cache() for globe change, > but it also need to change the code in test cases,because all of the > test cases, which need to download the file from internet , are make the > cache dir in self.bindir in method setup . > > So I choose this way to fix it, > Any comments ?
It's good enough for now. A better way to fix this would be to define self.cachedir on the base test class, so those tests (dacapo, dma_memtest and lsb_dtk) don't even need to define self.cachedir. I leave this as an exercise to the reader :) In case you decide to do this, remember to change the tests to remove the self.cachedir assignment entirely. Your patches have been applied with changes on the commit message (I've corrected your misspelling 'Chang' for 'change' on the commit messages as well). Thanks, Lucas _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
