On Wed, 2012-08-01 at 11:28 -0300, Lucas Meneghel Rodrigues wrote: > The obvious fix is to actually update the dict: > > diff --git a/client/virt/virt_test.py b/client/virt/virt_test.py > index deade2e..5912fd4 100644 > --- a/client/virt/virt_test.py > +++ b/client/virt/virt_test.py > @@ -86,6 +86,7 @@ class virt_test(test.test): > # Load the test module > f, p, d = imp.find_module(t_type, [subtest_dir]) > test_module = imp.load_module(t_type, f, p, d) > + test_modules[t_type] = test_module > f.close() > > # Preprocess > > Then it starts doing what you want. Now, with the fix, the patch looks > OK, but messing around with this core code might bring problems, and I'd > only accept it if we have things very well tested, to reduce the chance > of breakages. I've had enough trouble on Mon and Tue fixing bugs that > could have been caught by more careful testing (ok, the bugs are my > fault, but anyway, we need to be more careful).
^ In case my intention wasn't clear here, what I want is to have this tested in your infrastructure (or laptop), throw a couple of extensive test jobs, then send me an updated version that will make into next, OK? Thanks, Lucas _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
