Perhaps it will be better if we can specify a default hvm_or_pv='hvm' in configuration file such as tests.cfg instead of codes change, and then users will know it without checking actual codes.
-- Regards, Alex ----- Original Message ----- From: "Lucas Meneghel Rodrigues" <[email protected]> To: "Chris Evich" <[email protected]> Cc: [email protected] Sent: Friday, August 3, 2012 11:04:26 PM Subject: Re: [Autotest] [PATCH] libvirt: hvm_or_pv='hvm' when not specified On Thu, 2012-08-02 at 12:40 -0400, Chris Evich wrote: > On 08/02/2012 12:38 PM, Chris Evich wrote: > > Signed-off-by: Chris Evich<[email protected]> > > --- > > client/virt/libvirt_vm.py | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/client/virt/libvirt_vm.py b/client/virt/libvirt_vm.py > > index 29ba19d..7cae75c 100644 > > --- a/client/virt/libvirt_vm.py > > +++ b/client/virt/libvirt_vm.py > > @@ -1087,7 +1087,7 @@ class VM(virt_vm.BaseVM): > > virt_install_cmd += add_connect_uri(help, self.connect_uri) > > > > # hvm or pv specificed by libvirt switch (pv used by Xen only) > > - hvm_or_pv = params.get("hvm_or_pv") > > + hvm_or_pv = params.get("hvm_or_pv", "hvm") > > if hvm_or_pv: > > virt_install_cmd += add_hvm_or_pv(help, hvm_or_pv) > > > > I keep forgetting to add the 'hvm_or_pv' to my variants which results in > VERY slow guests :S Any objections to setting hvm as a default (when > not specified)? I'm fine with it, shouldn't bring headaches, although that might 'last words' (you never know what crazy host combination might break this assumption). I vote yes, please put this on next. _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
