On 08/07/2012 01:34 PM, Alex Jia wrote:
On 08/07/2012 06:25 AM, Lucas Meneghel Rodrigues wrote:
Hi Alex and Wayne:
I've dropped your virt_v2v patchset (12 patches) from next, considering
they were causing the following regression on next:
08/06 16:49:24 DEBUG| parallel:0030| UnhandledTestError: Unhandled
ImportError: No module named server.hosts.ssh_host
08/06 16:49:24 DEBUG| parallel:0030| Traceback (most recent call last):
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/parallel.py", line 18, in fork_start
08/06 16:49:24 DEBUG| parallel:0030| l()
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/job.py", line 529, in<lambda>
08/06 16:49:24 DEBUG| parallel:0030| l = lambda :
test.runtest(self, url, tag, args, dargs)
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/test.py", line 115, in runtest
08/06 16:49:24 DEBUG| parallel:0030|
job.sysinfo.log_after_each_iteration)
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/shared/test.py", line 929, in runtest
08/06 16:49:24 DEBUG| parallel:0030| exec ('import %s' %
modulename, local_namespace, global_namespace)
08/06 16:49:24 DEBUG| parallel:0030| File "<string>", line 1,
in<module>
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/tests/kvm/kvm.py", line 1, in<module>
08/06 16:49:24 DEBUG| parallel:0030| from autotest.client.virt
import virt_test
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/virt/virt_test.py", line 4, in<module>
08/06 16:49:24 DEBUG| parallel:0030| import virt_utils,
virt_env_process
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/virt/virt_env_process.py", line 6, in<module>
08/06 16:49:24 DEBUG| parallel:0030| import virt_remote,
virt_v2v, ovirt
08/06 16:49:24 DEBUG| parallel:0030| File
"/usr/local/autotest/virt/virt_v2v.py", line 10, in<module>
08/06 16:49:24 DEBUG| parallel:0030| from
autotest.server.hosts.ssh_host import SSHHost
08/06 16:49:24 DEBUG| parallel:0030| ImportError: No module named
server.hosts.ssh_host
Bottom line, you'll have to find another way to set up the ssh key in
virt_v2v, anything out of client or shared modules are out of limits for
code that is supposed to run on a client.
There are some methods are common for client and server such as setup
a ssh connection,
if we want to reuse codes rather than implementing them in client
again, IMHO, we should
abstract them as a module/method and put them into utils directory,
@lmr, what do you think?
in addition, which's module right place? utils/common.py?
I think the directory should be client/shared where storing libraries
which are common
to both client and server.
I have an up to date version of the patches on my tree:
https://github.com/lmr/autotest/tree/v2v
So you can recover the patches and fix out those 2 bugs (one, wrong
arguments passed to one class constructor and this problem just
mentioned here. Please recover the patches, fix out those bugs then
re-send a pull request.
If we can confirm above question, it's okay for us to fix them asap.
However, I'm worrying about it will have effect on all of server codes.
Yeah, the change will including move following functions:
1. setup_ssh and setup_ssh_key functions in server/hosts/ssh_host.py,
2. get_public_key in server/base_utils.py
The good thing is that i just grep the codes, if we keep
server/hosts/ssh_host.py intact there will be no other harm since only
ssh_host use these functions for now.
Thanks!
Wayne Sun (*gsun*@redhat.com)
2012-08-07
Regards,
Alex
If you have any doubts let me know,
Lucas
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
